Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deactivate mesh layer contours #52258

Merged
merged 1 commit into from Apr 25, 2023
Merged

fix deactivate mesh layer contours #52258

merged 1 commit into from Apr 25, 2023

Conversation

vcloarec
Copy link
Member

fix #51920
Deactivating the mesh contours is not possible since #50088, that was a regression.

@github-actions github-actions bot added this to the 3.32.0 milestone Mar 16, 2023
@vcloarec vcloarec added Regression Something which used to work, but doesn't anymore Bug Either a bug report, or a bug fix. Let's hope for the latter! Mesh Related to general mesh layer handling (not specific data formats) backport release-3_28 labels Mar 16, 2023
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 31, 2023
@vcloarec vcloarec removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 31, 2023
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 15, 2023
@vcloarec vcloarec removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 15, 2023
@vcloarec vcloarec merged commit 66c88af into master Apr 25, 2023
45 checks passed
@vcloarec vcloarec deleted the fix#51920 branch April 25, 2023 14:07
This was referenced Apr 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uclaros uclaros uclaros approved these changes

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Mesh Related to general mesh layer handling (not specific data formats) Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
3.32.0
Development

Successfully merging this pull request may close these issues.

Mesh layer "contours" do not stay turned off
2 participants
@vcloarec @uclaros