New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] losing WFS DCP endpoints upon cloning WFS URI #52648
Merged
rouault
merged 3 commits into
qgis:master
from
andreassteffens:fix-losing_WFS_DCP_endpoints
Apr 20, 2023
Merged
[fix] losing WFS DCP endpoints upon cloning WFS URI #52648
rouault
merged 3 commits into
qgis:master
from
andreassteffens:fix-losing_WFS_DCP_endpoints
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Apr 12, 2023
… properties to a another/new instance
rouault
added
backport queued_ltr_backports
Queued Backports
backport release-3_30
labels
Apr 20, 2023
rouault
approved these changes
Apr 20, 2023
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-52648-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 7aefbc15a7c1a9f35dfdad7e26d810228ea2276e,c50f78488b4dce62fbbd3b037abdf6670dd4d489,ab13ece4dc175f67b8a7203869c2aecb5e0a467a
# Push it to GitHub
git push --set-upstream origin backport-52648-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
qgis-bot
added
the
failed backport
The automated backport attempt failed, needs a manual backport
label
Apr 20, 2023
rouault
pushed a commit
to rouault/QGIS
that referenced
this pull request
Apr 20, 2023
backport to queued_ltr_backports in #52801 |
nyalldawson
pushed a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport queued_ltr_backports
Queued Backports
failed backport
The automated backport attempt failed, needs a manual backport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the WFS datasource URI is cloned (e. g. when applying an additional filter to a WFS layer) Get/Post DCP endpoints which have been originally parsed from the capabilities document are lost and all WFS operations fall back to using the capabilities URL.
This commit introduces two new getters to the
QgsWFSDataSourceURI
class which are used to transfer the stored endpoint informationen to a new instance upon cloning.