[FEATURE] Flash features #5268
Merged
[FEATURE] Flash features #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Nice! Is it working when we use the Locator bar to select a feature? |
Not yet, but should be quite straightforward to utilise it there |
m-kuhn
reviewed
Sep 29, 2017
src/gui/qgsmapcanvas.h
Outdated
| * \since QGIS 3.0 | ||
| * \see flashFeatureIds() | ||
| */ | ||
| void flashGeometries( QgsVectorLayer *layer, const QList< QgsGeometry > &geometries, |
There was a problem hiding this comment.
What do you think about making this accept a QgsCoordinateReferenceSystem instead of a QgsVectorLayer? This would make this usable for a wider range of applications.
There was a problem hiding this comment.
Agreed - I'll do that
|
Nice! |
|
Nice addition! |
secondary lines enabled
This adds: - API call to QgsMapCanvas to flash a set of features - A right click menu option in the attribute table to flash the clicked feature - An option in the Search by Form dialog to flash matching features When triggered, the features flash allowing easy identification without having to alter the current selection or map extent
Fixes potential crash
Use a QgsCoordinateReferenceSystem object instead of QgsVectorLayer to make API more flexible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
When triggered, the features flash allowing easy identification without having to alter the current selection or map extent
Screencast at https://youtu.be/pzIxAwzqaPM