Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs-docs] Rename simplify_vw to simplify_by_area #5274

Closed
wants to merge 1 commit into from

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Sep 30, 2017

fixes #16407
The idea is to have a more meaningful name than before... @nyalldawson ?
image

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nyalldawson
Copy link
Collaborator

We have a loose convention that expression functions follow the same name as their equivalent postgres/postgis, but dropping any "st_" prefixes. In this case the equivalent postgis function is "st_simplifyvw".

I do like your name better, but I'm reluctant to vary from this convention.

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 1, 2017

I was not sure if we were still following the PG functions naming. And if we do, yes, let's keep the equivalent naming although it's not obvious. 😢
Thanks

@DelazJ DelazJ closed this Oct 1, 2017
@DelazJ DelazJ deleted the simplify_by_area branch October 6, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants