QgsBrowserGuiModel::flags(): cache value for faster browser redrawn (refs #53265) #53267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops -- overlapping fix is in #53268 I think both are compatible though. The only issue with handling caching in the model is that we can't respond to external changes, eg some new QgsDataItemGuiProvider which a plugin installs which implements drop support for an item. |
… drop values (refs qgis#53265)
rouault
force-pushed
the
faster_browser_refresh
branch
from
686de23
to
ce83b23
Compare
addressed per commit ce83b23 |
nyalldawson
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nyalldawson I see you've assigned yourself just when I was debugging this myself too. (my fault, should have assigned myself)
I couldn't reproduce the big lag @jfbourdon mentions (the folder with the 130 .gdb opens in < 2 seconds for me), but when panning it, I could see that each .gdb item displayed was opened to call its acceptDrop() method, which caused a small but perceptible lag.
Not totally sure about my fix. I considered adding a setter/getter in QgsDataItem itself, but that didn't feel much elegant to put there the result of caching.