OGR Field domain creation: properly convert QVariant to expect OGR data type #53314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta type (fixes qgis#52318) This fixes the main issues: crashes / data corruption. Note however that currently the GeoPackage driver doesn't really support storing the data type of a field domain, so on reading, range domains are always read as of type Real (unless there is a layer field associated with that domain). An idea could be to (ab)use the description field of the GeoPackage system table to include a conventional suffix like " (type Integer)" that would be automatically set and stripped off by the OGR GPKG driver. It could also be nice that the QGIS GUI only proposes types that make sense for the underlying provider, but there's a lack of infrastructure for that.
nyalldawson
approved these changes
Jun 3, 2023
lbartoletti
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #52318)
This fixes the main issues: crashes / data corruption.
Note however that currently the GeoPackage driver doesn't really support storing the data type of a field domain, so on reading, range domains are always read as of type Real (unless there is a layer field associated with that domain). An idea could be to (ab)use the description field of the GeoPackage system table to include a conventional suffix like " (type Integer)" that would be automatically set and stripped off by the OGR GPKG driver.
It could also be nice that the QGIS GUI only proposes types that make sense for the underlying provider, but there's a lack of infrastructure for that.