Fix point text annotation rotation, alignment issues and expose settings to GUI #53337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whereas every other angle in qgis api is set in clockwise directions This setting has never been exposed to users, so we are free to change it now as it will always be 0 in any existing projects
This was supported by the annotation, but not exposed in the widget for some reason
the text annotation should handle map rotation Previously, text annotations just ignore map rotation, which matches how regular map labels are handled. But this is not desirable for some point text annotations, where it can be considered a bug that the item ignores the map rotation (eg when a text annotation has been placed to align with a feature on the map, such as a road) There's no one "correct" behaviour here, so add a new combo box widget in the annotation point text settings with options for "Ignore Map Rotation" "Rotate With Map" so that users can pick the desired behavior for their annotations
This has been supported via raw api, but not exposed in the widget
nirvn
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of issues relating to handling rotation and text alignment of point text annotation items, which was previously available via PyQGIS but not exposed via the GUI.