do not explicitly mark source widget as valid as this overrides validation result (fix #52622) #53359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation result (fix #52622)
alexbruy
added
Bug
nyalldawson
reviewed
Jun 8, 2023
nyalldawson
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding an XYZ layer from the Datasource Manager by enetering an URL directly, the "Add" button remains disabled even if entered URL is valid. It also remains disabled when connection selected from the combobox.
Seems this happens because source widget is validated, but then explicitly marked as a valid overriding validation results and not emiting a signal.
Fixes #52622.