set default value for CRS parameter in Define Shapefile projection algorithm (fix #53309) #53388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithm (fix #53309) If default value is not set and prameter is not optional its widget end up in conflicting state: invalid CRS is set but widget requires a valid one. As a result even if user selects a valid crs, widget fails to validate selection.
alexbruy
added
Processing
nyalldawson
approved these changes
Jun 7, 2023
|
We should also merge #53393, which fixes the related issues in the widget itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a default value for parameter is not set, the parameter should be marked as optional in order to have proper support for invalid CRS in the widget. If widget does not allow invalid CRS but invalid CRS is set, it will fail to validate selection.
Fixes #53309.