Remove OpenStreetMap integration in analysis lib + app #5354
Conversation
wonder-sk
force-pushed
the
bye-bye-osm
branch
from
a2c3f89
to
f7418a0
Compare
|
Can we keep the qgsosmdownload.h? I was going to use it while I'm porting QuickOSM to QGIS 3.
This is not a problem. Overpass API is not supporting PBF as an output so we can't avoid the XML file. But I agree, we should use the OSM driver in OGR (supporting XML and PBF) |
It is quite a small and simple file, so it would be a better if you port it to Python for your use case... I don't think we should keep it around just for that... |
|
@wonder-sk could you add a [needs-docs] tag, please? This feature is documented in the user manual and is the base tool to download data in the Training manual. Hence docs would need some update... |
|
no worries, I was just lazzy ;-) It seems PBF is coming on the overpass API now: http://gis.19327.n8.nabble.com/PBF-output-prototype-available-for-testing-td5884534.html good news ! So yes, maybe better to use the OGR driver now with PBF |
|
@DelazJ that tag needs to go to the commit message or is pull request title also a good place? |
|
@wonder-sk From what i've experienced, renaming the PR isn't enough (in my case this renaming didn't generate the expected issue report in Docs) |
|
It might depend if you rebase or merge your PR? Updating the title of the PR might be useless if you do a rebase on github. My 2 cents |
- unmaintained and barely working anymore - clunky GUI - not supporting .pbf - there are other python plugins doing the same thing better - nobody is using it anymore https://lists.osgeo.org/pipermail/qgis-developer/2017-October/050103.html
wonder-sk
force-pushed
the
bye-bye-osm
branch
from
f7418a0
to
84741dd
Compare
|
@DelazJ cool - I have updated the commit message to include [needs-docs] |
Also be aware that the if you're porting that class to python, you might want to take a look at QgsFileDownloader and take inspiration from it instead. It has correct handling for redirects and authentication handling, which the OSM downloader doesn't have. |
Why:
For reference: https://lists.osgeo.org/pipermail/qgis-developer/2017-October/050103.html