Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3d] add show labels toggle, default to off #5361

Merged
merged 1 commit into from Oct 13, 2017

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Oct 13, 2017

Description

@wonder-sk , you give me a working mouse pan, I give you a label toggle setting 馃槈

Newly-added setting is found right here:
screenshot from 2017-10-13 15-25-48

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nirvn nirvn requested a review from wonder-sk October 13, 2017 08:28
Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one detail, could you add support for this flag also to readXml/writeXml methods? They are not used right now, but they will be soon :-)

@nirvn
Copy link
Contributor Author

nirvn commented Oct 13, 2017

@wonder-sk , done. Thanks for the swift review.

@nirvn nirvn merged commit b250729 into qgis:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants