[processing] Always list native algorithms before 3rd party providers #5369
Conversation
|
+1 to remove the number of algorirhms from 3rd party group labels. I would go as far as using a shade of gray for matching 3rd party algs when searching. |
@nirvn @nyalldawson
|
|
many QGIS tools (i.e. the python ones) are not yet as robust (i.e.
intersection, unions, etc) or fast (i.e dissolve) as they "3rd party"
counterparts and in some case even returning wrong results or don't work at
all with some inputs. Not I would not (and I don't) suggest them to be
used, but they are so dangerous they should be removed until fixed.
Not sure this is the case anymore. Didn't Nyall rewrite all of these now
in C++?
…On Sun, Oct 15, 2017 at 11:36 PM, Giovanni Manghi ***@***.***> wrote:
+1 to remove the number of algorirhms from 3rd party group labels.
I would go as far as using a shade of gray for matching 3rd party algs
when searching.
@nirvn <https://github.com/nirvn> @nyalldawson
<https://github.com/nyalldawson>
I'm sorry, don't get me wrong, but why? I agree that the goal should be
that, but:
- GRASS, SAGA, OTB offer hundreds of tools that QGIS does not
- Showing the number is a great way we have in trainings that QGIS
offers anyway an amount of tools that is comparable to other geoprocessing
toolboxes (arcgis anyone?)
- many QGIS tools (i.e. the python ones) are not yet as robust (i.e.
intersection, unions, etc) or fast (i.e dissolve) as they "3rd party"
counterparts and in some case even returning wrong results or don't work at
all with some inputs. Not I would not (and I don't) suggest them to be
used, but they are so dangerous they should be removed until fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5369 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXS3Iw2Vw3RwMUTpjAMOPeEA3EzJx5hks5ssfwwgaJpZM4P5r-X>
.
|
-1 on this... to me that conveys "disabled" or "inactive", neither of which applies here! It's important to note that I'm not wanting to relegate external providers to second class citizens - instead I'm trying just to promote use of QGIS native algorithms as the suggested algorithms (for reasons discussed at length elsewhere).
To clarify, which parts are you against:
Re 3: I HATE HATE HATE UI inconsistencies and complexity. In my opinion the algorithm count (and also the version number, but i'll discuss that later) violates both of these. Check out this screenshot of master:
I'm sure we can agree that there's a consistency issue here - either every group needs the count, or none of them. 2.x approach is to show count for everything:
But I dislike that from a ui complexity viewpoint. There's way too much text here, and the actual useful bit ("GDAL"/"SAGA"/"GRASS"/"Models"/"Scripts" etc) is buried so far under all the extra text ("(2.3.2) [324 geoalgorithms]" / "GIS 7 commands [315 geoalgorithms]" etc) that it's a real strain to read this list and find what you're looking for. I'd bet most users rely on the icons alone for identifying groups. My solutions would be (in order of preference):
|
|
+1 for algorithms count removal. This information is not necessary at all. Version number was useful some time ago when we supported multiple versions of same provider (e.g. SAGA 2.3.x and 2.2.x) but now it is also not really useful. |
nyalldawson
force-pushed
the
toolbox_order
branch
from
2ca77f9
to
b95e854
Compare
|
I've pushed a commit which drops the extra text. Here's what it looks like with that in place:
Let me know if I should leave this commit in or not... |
|
@nyalldawson , big +1 from me. I might have gone overboard with my suggestion to use gray after all 😉 |
|
Tooltips might also be a good possibility to show extra information (versions for 3rd party algs) in an unobtrusive way. What do you think @gioman ? |
sounds a good solution |
This change ensures that searching for algorithms always returns native algorithms before matching 3rd party algorithms TODO: we really need to replace the toolbox tree with a proper model and redo the sorting/filtering using a sort/filter proxy model.
…ltips Add version number to gdal provider long name
nyalldawson
force-pushed
the
toolbox_order
branch
from
b95e854
to
4ce1662
Compare
Done! |
In QGIS 3.0 we are trying to push users towards trying native QGIS algorithms first.
This change ensures that searching for algorithms always returns native algorithms before matching 3rd party algorithms:
Question: should we be removing the "[45 geoalgorithms]" text from the GDAL group? I don't see it as particular relevant and just additional noise, and it's also a bit odd in the above screenshot since there's clearly not 45 matching algorithms for that search phrase...