Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] correctly handle layers without attributes in GDAL-based geoprocessing algorithms (fix #17287) #5436

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Oct 24, 2017

Description

Correctly handle layers without without attributes in GDAL-based geoprocessing algorithms. Fixes https://issues.qgis.org/issues/17287. Supersedes #5397

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nyalldawson
Copy link
Collaborator

Looks good to me - @gioman are you ok for this to be merged?

@gioman
Copy link
Contributor

gioman commented Oct 26, 2017

Looks good to me - @gioman are you ok for this to be merged?

sure!

@nyalldawson nyalldawson merged commit 034baf1 into qgis:master Oct 26, 2017
@alexbruy alexbruy deleted the processing-gdal-memory branch October 26, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants