Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymise logs when loading a project from postgresql #54650

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Anonymise logs when loading a project from postgresql #54650

merged 11 commits into from
Sep 21, 2023

Conversation

pblottiere
Copy link
Member

Description

Fixes #54437

@github-actions github-actions bot added this to the 3.34.0 milestone Sep 18, 2023
troopa81
troopa81 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@troopa81 troopa81 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a cosmetic modification

src/core/qgsdatasourceuri.cpp Outdated Show resolved Hide resolved
Gustry
Gustry approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

tests/src/core/testqgsdatasourceuri.cpp Outdated Show resolved Hide resolved
uclaros
uclaros reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uri with the clear text password is also visible in the Open Recent menu items as well as in the project properties

src/core/qgsdatasourceuri.cpp Outdated Show resolved Hide resolved
@pblottiere
Copy link
Member Author

The uri with the clear text password is also visible in the Open Recent menu items as well as in the project properties

@uclaros Connection strings are now anonymized in project properties and welcome page. Thanks for the input 👍

@Gustry
Copy link
Contributor

Gustry commented Sep 19, 2023

Nice update, thanks !
Do you think it can be backported ? It would avoid any confusion about missing password.

I can review all usages of removePassword, I added 2 I think : server and UI recently.

@pblottiere
Copy link
Member Author

Hello @troopa81 ✋,

Do you agree with the last modifications? Because CI is green so I can merge.

troopa81
troopa81 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doc comment, the rest looks good

src/core/qgsdatasourceuri.h Show resolved Hide resolved
@troopa81 troopa81 merged commit e5e6a13 into qgis:master Sep 21, 2023
29 checks passed
@Gustry Gustry mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uclaros uclaros uclaros left review comments

@Gustry Gustry Gustry approved these changes

@troopa81 troopa81 troopa81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.34.0
Development

Successfully merging this pull request may close these issues.

Database string connection visible in the message bar/QGIS logs
4 participants
@pblottiere @Gustry @uclaros @troopa81