Fix vertical labeling when rotation is 270°

[pblottiere]

Description

See #54598

The label cannot be put in this position on master when Show upside-down labels is set to never:

[nyalldawson]

This test mask doesn't look right -- it's negating the whole test

[pblottiere]

Hi @nyalldawson,

This test mask doesn't look right -- it's negating the whole test

Yes you're right, I updated the control image instead. Let me know if it suits you better.

[nyalldawson]

@pblottiere I agree that the updated test image is arguably correct. But I'm slightly concerned about the risk of regressions here -- the logic with upside down label handling is extremely complex 😱

Could you add new tests with rotation +/- 1 degree off vertical so that we've got a test which still covers a similar use case as the existing one with vertical text?

[pblottiere]

But I'm slightly concerned about the risk of regressions here -- the logic with upside down label handling is extremely complex 😱

Yes I understand. I won't be surprised if this PR is finally not merged :).

Could you add new tests with rotation +/- 1 degree off vertical so that we've got a test which still covers a similar use case as the existing one with vertical text?

I'm taking a look.

[pblottiere]

Hello @nyalldawson,

CI is green 🎉. Let me know what you think :). Thanks!

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.