-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPATIALITE: fix insert incompatible geometry types #54734
SPATIALITE: fix insert incompatible geometry types #54734
Conversation
0a457af
to
3b04f8d
Compare
@rouault all changes done |
Fix qgis#54662 Logic shamelessly copied from potgres provider.
e0dd434
to
3cac4c0
Compare
@rouault the oapif and wfs providers are using spatialite in a separate thread, which was hitting the thread check here https://github.com/qgis/QGIS/blob/master/src/core/vector/qgsvectordataprovider.cpp#L899 Now, the only instance method called is a read-only wkbType(), wkb type is not supposed to be changed by the provider so the implementation should be thread safe but for extra safety I decided to create a new static version of the method and proxy the instance method to the static call. Can you please please review my last changes? |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-54734-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ed64f37b51bdf4b5024d2251b4fe5020de14f50d,30cd5124484b258f9054ad1e41487c87c415ab25,d462078894b8edd7312a2eab78b96ec13b807498,d98fb4d2cf682a448a48f6e1abf6d65f742d1538,3cac4c0b0be793a3eb18a9b8a51d4ed5f9fa5de2,7bd457b2bdd8cdd1dcfe247f70b70e89b7f073cd
# Push it to GitHub
git push --set-upstream origin backport-54734-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
Manual backport of qgis#54734 Fix qgis#54662 Logic shamelessly copied from potgres provider.
Fix #54662
Logic shamelessly copied from potgres provider.