Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have QgsRectangle::asPolygon return "EMPTY" for null rects #54831

Merged
merged 3 commits into from Oct 5, 2023
Merged

Have QgsRectangle::asPolygon return "EMPTY" for null rects #54831

merged 3 commits into from Oct 5, 2023

Conversation

strk
Copy link
Contributor

@strk strk commented Oct 4, 2023

Update python test accordingly

@github-actions github-actions bot added this to the 3.34.0 milestone Oct 4, 2023
@strk strk mentioned this pull request Oct 4, 2023
Merged
@strk
Copy link
Contributor Author

strk commented Oct 4, 2023

\cc @benoitdm-oslandia

nyalldawson
nyalldawson approved these changes Oct 4, 2023
View reviewed changes
src/core/geometry/qgsrectangle.cpp Outdated Show resolved Hide resolved
src/core/geometry/qgsrectangle.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson enabled auto-merge (rebase) October 4, 2023 22:56
@nyalldawson nyalldawson merged commit 5566e42 into qgis:master Oct 5, 2023
30 checks passed
@strk strk deleted the print-empty-rect branch October 5, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.34.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strk @nyalldawson