Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgs3daxissettings: Correctly read viewport ratio on a saved project #54870

Merged
merged 1 commit into from
Oct 8, 2023

Commits on Oct 7, 2023

  1. qgs3daxissettings: Correctly read viewport ratio on a saved project

    When loading a project which contains a 3D view, the 3D axis is not
    visible even when it is supposed to be displayed. This is because the
    min and max viewport ratio settings are always equal to 0 on a saved
    project. Indeed, these settings are supposed to handle the 3D axis
    visibility when the 3D view size changes: the axis are hidden when the
    view becomes too small.
    These ratio are stored as double between 0 and 1. However, the logic
    which reads these parameters from a saved
    project (`Qgs3DAxisSettings::readXml`) parses them as
    integer. Therefore, the min and max ratio are always equal to 0. Then,
    the 3D axis visibility test is always false and the 3D axis are always
    hidden.
    
    This issue is fixed by changing `Qgs3DAxisSettings::readXml` to read
    the ratios as double.
    ptitjano committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    6eb7268 View commit details
    Browse the repository at this point in the history