Remove use of QgsLayoutEffect #54907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGraphicsEffects should NOT be used on QGraphicsItems. Despite being part of stable Qt API, it is broken and results in crashes. See https://bugreports.qt.io/browse/QTBUG-58501 for details.
This was only used to handle blend mode rendering of items, and causes crashes which cannot be worked around. We have to kill it and move to manual handling of blend modes for the items Fixes qgis#52079, likely many other crashes in layouts
2 tasks
nirvn
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only used to handle blend mode rendering of items, and causes crashes which cannot be worked around. We have to kill it and move to manual handling of blend modes for the items
QGraphicsEffects should NOT be used on QGraphicsItems. Despite being part of stable Qt API, it is broken and results in crashes. See https://bugreports.qt.io/browse/QTBUG-58501 for details.
Fixes #52079, likely many other crashes in layouts
Fixes #54907