-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D extent to providers (1st stage) #54941
Add 3D extent to providers (1st stage) #54941
Conversation
f68481b
to
aa362be
Compare
This is great! Can you add the missing doxygen since notations too? (I assume this is targeting 3.36?) |
@benoitdm-oslandia , exciting stuff! What immediately comes to mind here is the possibility to do elevation filtering for the map canvas (the same way we do temporal filtering) with provider-side filtering capability. Lovely. Out of curiosity, what are you guys planning to do with this? |
@nirvn we are looking to push an improved extent filtering in the 3D view like this preview: |
732ef36
to
78b531f
Compare
78b531f
to
6375a51
Compare
@rouault @nyalldawson can you review this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for a minor nitpick
As I mentionned I'm a bit nervous for performance reasons seing QgsVectorLayer::extent() to be redirected to QgsVectorLayer::extent3D().toRectangle(). |
I can re-add the previous code for the |
…tionProperties to parent class This allows provider classes to have a useable elevation properties class, for example to know if the provided data is 3D or 2D. This will be useful to compute 3D/2D extent.
…ataProviderElevationProperties
6375a51
to
8d1155d
Compare
@rouault @lbartoletti @nyalldawson all requests are fulfilled. Is it OK for you? |
🍾 |
This PR brings core modifications to allow providers to handle 3D extent. This is the first stage to prepare next PRs with dedicated modifications per provider.
Funded by CEA/DAM @renardf
cc @ptitjano