Use valid extent in testRegisterFeatureUnprojectible #55011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was meant to catch a crasher upon being unable to project a feature. Today it looks like QGIS is able to project the feature and generate a label for it, but the test still reports no features being added only because the "visible extent" (set to the map) is empty.
nyalldawson
approved these changes
Oct 21, 2023
|
Should this be backported ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was meant to catch a crasher upon being unable to project a feature. Today it looks like QGIS is able to project the feature and generate a label for it, but the test still reports no features being added only because the "visible extent" (set to the map) is empty.
I will push a commit making the feature back unprojectible but first I want to verify that the "invisible extent" is the reason why the test did not start failing upon the feature became projectible. If this is the case, we should see the test fail, now that we use a valid map extent.
This is a spin-off of #54954 (comment)