[Postgres] Remove listener wait condition

[troopa81]

Fixes #54260

The issue was because of 2 things:

• credential were requested though it was not necessary (auth configuration needed to be extended)
• Display the credential dialog was not possible because of the main thread blocking waitCondition

This PR propose to create the connection and execute the listen request in the main thread and then doing the listening on the thread. This way, we still can garantee listening is set when setListening() ends and not block UI if credentials dialog need to popup.

I also reworked code a bit to use a plain QgsPostgresConn and log the listen connection.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[troopa81]

@elpaso Do you mind reviewing this PR please ?

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[troopa81]

@strk Do you mind reviewing this PR ?

[strk]

Had you tried adding a testcase showing the crash ? I'd start there. I see fixes but I would prefer to see the crash first, and doing it with a test ensures it won't happen again in the future.

[troopa81]

Had you tried adding a testcase showing the crash ? I'd start there. I see fixes but I would prefer to see the crash first, and doing it with a test ensures it won't happen again in the future.

You can do what is described in #54260 but you have to have a configuration authentication for the database layer. That's the main reason of the crash.

[strk]

You can do what is described in #54260 but you have to have a configuration authentication for the database layer. That's the main reason of the crash.

I meant an automated test, one that is run as part of `make check` and that can be run in isolation with a `ctest` invocation. Can you try to write such test ?

[troopa81]

Can you try to write such test ?

I thought about it but there is thread and UI synchronization involved, it's a mess to test and would be very hard to make a non-flaky test about it

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit b20a5d0)

[troopa81]

Thanks for the review @elpaso