-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate grass .txt descriptions to single .json file #55513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
added
Optimization
I feel the need... the need for speed!
Processing
Relating to QGIS Processing framework or individual Processing algorithms
labels
Dec 5, 2023
nyalldawson
force-pushed
the
grass_files
branch
from
December 6, 2023 02:07
3f82f73
to
b159181
Compare
Refs #54563 |
alexbruy
approved these changes
Dec 7, 2023
Remove betweeness from dict -- it breaks spell checking of grass files and isn't a common enough word to warrant more intrusive workarounds
nyalldawson
force-pushed
the
grass_files
branch
from
December 8, 2023 02:04
b159181
to
1dd70c7
Compare
Great 🙂! BTW does this also generalize the 'grass7' provider ID to just 'grass', since currently GRASS 8 is the version in use? I encountered users and R developers being confused by the 'grass7' label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GRASS
Optimization
I feel the need... the need for speed!
Processing
Relating to QGIS Processing framework or individual Processing algorithms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to improve the QGIS startup speed, especially on Windows where opening and parsing the hundreds of description .txt files is SLOOOOOOW. This contributes significantly to the overall speed of loading QGIS on Windows, especially on new installs/cold starts.
To avoid this, the .txt description files are aggregated into a single .json unified file, which can be quickly opened and read in one go.
The json file is built using the new
description_to_json.py
script, which must be run whenever any of the .txt description files are updated.