Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFS provider] Handle documents with Complex Feature schemas (using OGR GMLAS driver), and JSON'ify content of complex properties #55847

Merged
merged 21 commits into from Feb 20, 2024
Merged

[WFS provider] Handle documents with Complex Feature schemas (using OGR GMLAS driver), and JSON'ify content of complex properties #55847

merged 21 commits into from Feb 20, 2024

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jan 15, 2024 •
edited

Fixes qgis/QGIS-Enhancement-Proposals#277, fixes #27076, fixes #52227, fixes #54942

Example with https://inspire.brandenburg.de/services/ps_schutzg_wfs:

image

Funded by QGIS user group Germany (QGIS Anwendergruppe Deutschland e.V.)

@github-actions github-actions bot added this to the 3.36.0 milestone Jan 15, 2024
@rouault rouault force-pushed the wfs_complex_content branch 2 times, most recently from 6360f65 to c1f1067 Compare January 15, 2024 16:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit f017314)

@rouault rouault force-pushed the wfs_complex_content branch 2 times, most recently from 66ab7b8 to 7476a34 Compare January 15, 2024 17:45
@pathmapper
Copy link
Contributor

Selecting all layers to add from https://inspire.brandenburg.de/services/ps_schutzg_wfs

results in adding only the GeometryCollection layer:

Any idea what could cause this? I'm using a totally fresh build...

@rouault
Copy link
Contributor Author

rouault commented Jan 15, 2024

Any idea what could cause this? I'm using a totally fresh build...

I don't reproduce this. All layers gets added for me

@pathmapper
Copy link
Contributor

Do you get also failing SSL handshakes?

@rouault
Copy link
Contributor Author

rouault commented Jan 15, 2024

Do you get also failing SSL handshakes?

yes, I believe there are server deficiencies

@rouault rouault force-pushed the wfs_complex_content branch 5 times, most recently from e6e42c4 to 7fc709f Compare January 16, 2024 11:38
@pathmapper pathmapper mentioned this pull request Jan 16, 2024
Closed
2 tasks
@pathmapper
Copy link
Contributor

pathmapper commented Jan 17, 2024 •
edited

Do we want/need to provide an easy way to clear the local gmlas_xsd_cache?

E.g. in Settings -> Options-> Network -> Cache Settings ?

@rouault
Copy link
Contributor Author

rouault commented Jan 17, 2024

Do we want/need to provide an easy way to clear the local gmlas_xsd_cache?

E.g. in Settings -> Options-> Network -> Cache Settings ?

done

@pathmapper
Copy link
Contributor

I don't reproduce this. All layers gets added for me

I can reproduce this on two different machines with Ubuntu using fresh builds of the PR branch, but it happens only if

  • the feature type is drag'n'dropped from the QGIS browser panel to the layer panel
    AND
  • "Add layers to group" is NOT checked.

It's worth to note that I can reproduce this also on QGIS 3.32.3 on Windows using the official standalone installer from qgis.org.
Test case: https://xplanservices.krzn.de/viersen/xplansyn-wfs/services/xplansynwfs and FeatureType xplan:BP_AnpflanzungBindungErhaltung.

rouault added a commit to rouault/QGIS that referenced this pull request Jan 19, 2024
@rouault
QgisApp::dropEvent(): workaround issue with WFS and sublayers
01ab6f5 
Cf scenario of qgis#55847 (comment)
@rouault
Copy link
Contributor Author

rouault commented Jan 19, 2024

Test case: https://xplanservices.krzn.de/viersen/xplansyn-wfs/services/xplansynwfs and FeatureType xplan:BP_AnpflanzungBindungErhaltung.

well, this layer has 0 feature (https://xplanservices.krzn.de/viersen/xplan-wfs/services/wfs60?SERVICE=WFS&REQUEST=GetFeature&VERSION=2.0.0&TYPENAMES=xplan:BP_AnpflanzungBindungErhaltung&RESULTTYPE=hits returns 0), hence when the logic to guess the geometry type is run, it can't conclude on it, and adds its as a geometry-less table. This has nothing to do with the way the layer is added.

But I do reproduce the issue with xplan:BP_Plan or https://inspire.brandenburg.de/services/ps_schutzg_wfs . After investigating for hours, I've finally found a ugly work around, added as a commit. There's definitely something I don't understand (some notification of added layers lost), but the work around seems to work...

@pathmapper
Copy link
Contributor

After investigating for hours

Sorry to hear, I'll send you a message.

I've finally found a ugly work around

Confirmed this fixes the issue 🎉

@pathmapper
Copy link
Contributor

pathmapper commented Jan 20, 2024 •
edited

INSPIRE WFS which can not be loaded correctly:

@pathmapper
Copy link
Contributor

For

QGIS freezes when adding FeatureType Netz / net:Network .

pathmapper
pathmapper reviewed Jan 20, 2024
View reviewed changes
Copy link
Contributor

@pathmapper pathmapper left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When loading e.g. https://inspire.brandenburg.de/services/ps_schutzg_wfs, there are a lot of warnings logged to the Linux console (see below). I guess they are coming from the GMLAS driver. Do they belong here?

Console warnings (click to expand) 
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_v
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_f
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_d
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_e
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_uuidref identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_uuidr
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_URL identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeList identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeListValue identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeSpace identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_chara
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_v
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_f
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_d
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_e
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_uuidref identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_uuidr
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_URL identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeList identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeListValue identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeSpace identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_chara
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_v
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_f
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_d
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_e
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_uuidref identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_uuidr
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_URL identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeList identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeListValue identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeSpace identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_chara
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationSoundLink identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nilReason identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA_nil identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: GeographicalName_pronunciation_PronunciationOfName_pronunciationIPA identifier truncated to geographicalname_pronunciation_pronunciationofname_pronunciatio
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_v
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_responsibleparty_contactinfo_ci_contact_phone_ci_telephone_f
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_i
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_u
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_d
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_city_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_administrativeArea_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_a
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_postalCode_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_p
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_country_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_c
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_responsibleparty_contactinfo_ci_contact_address_ci_address_e
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_uuidref identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_uuidr
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_id identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_uuid identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_linkage_URL identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_protocol_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_applicationProfile_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_name_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_description_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeList identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeListValue identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode_codeSpace identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_onlineResource_CI_OnlineResource_function_CI_OnLineFunctionCode identifier truncated to ci_responsibleparty_contactinfo_ci_contact_onlineresource_ci_on
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_nilre
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_hoursOfService_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_hoursofservice_chara
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_nilReason identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_ResponsibleParty_contactInfo_CI_Contact_contactInstructions_CharacterString identifier truncated to ci_responsibleparty_contactinfo_ci_contact_contactinstructions_
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_voice identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_phone_CI_Telephone_facsimile identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_deliveryPoint identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin
Warning 1: CI_Citation_citedResponsibleParty_CI_ResponsibleParty_contactInfo_CI_Contact_address_CI_Address_electronicMailAddress identifier truncated to ci_citation_citedresponsibleparty_ci_responsibleparty_contactin

rouault added a commit to rouault/QGIS that referenced this pull request Jan 20, 2024
@rouault
QgsGmlStreamingParser: fix quadratic performance pattern when parsing…
0d8649d 
… huge JSON content

Addresses issue with qgis#55847 (comment)
and parsing of "https://www.wfs.nrw.de/geobasis/wfs_nw_inspire-gewaesser-netzwerk_atkis-basis-dlm?SERVICE=WFS&REQUEST=GetFeature&VERSION=2.0.0&TYPENAMES=net:Network&COUNT=1&SRSNAME=urn:ogc:def:crs:EPSG::25832&NAMESPACES=xmlns(net,http://inspire.ec.europa.eu/schemas/net/4.0)&NAMESPACE=xmlns(net,http://inspire.ec.europa.eu/schemas/net/4.0"
which is a 44 MB single WFS feature...
@rouault
Copy link
Contributor Author

rouault commented Jan 20, 2024 •
edited

QGIS freezes when adding FeatureType Netz / net:Network .

Partially fixed per 0d8649d . This does fix the performance bottleneck on the GML parsing code I added. But in practice this is barely usable as QGIS freezes when trying to display this single feature that is 44 MB large with the QgsJsonEditWidget
Below stacktrace:

#0  0x00007fa869dcc79a in Scintilla::Editor::WndProc(unsigned int, unsigned long, long) () from target:/lib/libqscintilla2_qt5.so.15
#1  0x00007fa869b8b3e2 in QsciScintilla::text() const () from target:/lib/libqscintilla2_qt5.so.15
#2  0x00007fa86c994fd3 in QgsJsonEditWidget::refreshTreeViewItem (this=0x559b8ffef370, treeWidgetItem=0x559b99fe85f0, jsonValue=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwidget.cpp:322
#3  0x00007fa86c99527d in QgsJsonEditWidget::refreshTreeViewItem (this=0x559b8ffef370, treeWidgetItem=0x559b99fed900, jsonValue=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwidget.cpp:346
#4  0x00007fa86c9947b9 in QgsJsonEditWidget::refreshTreeView (this=0x559b8ffef370, jsonDocument=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwidget.cpp:274
#5  0x00007fa86c99389c in QgsJsonEditWidget::setJsonText (this=0x559b8ffef370, jsonText=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwidget.cpp:97
#6  0x00007fa86c991721 in QgsJsonEditWrapper::updateValues (this=0x559b8ffeeef0, value=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwrapper.cpp:77
#7  0x00007fa86c95159d in QgsEditorWidgetWrapper::setValue (this=0x559b8ffeeef0, value=...) at /home/even/qgis/qgis/src/gui/editorwidgets/core/qgseditorwidgetwrapper.cpp:85
#8  0x00007fa86c991605 in QgsJsonEditWrapper::setFeature (this=0x559b8ffeeef0, feature=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwrapper.cpp:68
#9  0x00007fa86cf9d985 in QgsAttributeForm::resetValues (this=0x559b906cce50) at /home/even/qgis/qgis/src/gui/qgsattributeform.cpp:919
#10 0x00007fa86cf99f01 in QgsAttributeForm::setFeature (this=0x559b906cce50, feature=...) at /home/even/qgis/qgis/src/gui/qgsattributeform.cpp:315
#11 0x00007fa86cf988a1 in QgsAttributeForm::QgsAttributeForm (this=0x559b906cce50, vl=0x559b8d2d7870, feature=..., context=..., parent=0x0) at /home/even/qgis/qgis/src/gui/qgsattributeform.cpp:92

#4  0x00007fa86c9947b9 in QgsJsonEditWidget::refreshTreeView (this=0x559b8ffef370, jsonDocument=...) at /home/even/qgis/qgis/src/gui/editorwidgets/qgsjsoneditwidget.cpp:274
(gdb) print jsonDocument.array().size()
$6 = 370315

So basically the Json widget must deal with an array of > 370,000 elements...
I'm not sure what the resolution of this should be. I've no idea ifI strongly doubt the performance could be fixed while displaying everything. A potential resolution would be to say "well let's truncate the output to the first 100 or 1000 and last elements, and add a "... snip ..." string in the middle", but that's questionable...

When loading e.g. https://inspire.brandenburg.de/services/ps_schutzg_wfs, there are a lot of warnings logged to the Linux console

Addressed per c348cb8

@pathmapper
Copy link
Contributor

pathmapper commented Jan 20, 2024 •
edited

A potential resolution would be to say "well let's truncate the output to the first 100 or 1000 and last elements, and add a "... snip ..." string in the middle", but that's questionable...

So the issue is that the attribute table currently freezes with such an amount of data because there is no performant way to display it with QgsJsonEditWidget, right?

Some thoughts:

But the data is available (in memory?) and JSON'ified, right? Could we offer the JSON in such case from the attribute table / field value "for download" as file, e.g. storing it in cache/temp and show a file link, or offer the option to save the JSON to a location specified by the user? This would allow to inspect the whole JSON e.g. with a text editor or something else...

How could we determine if we are having a case where we can't show the JSON in the attribute table and fall back to something else?

If the issue is related to the QgsJsonEditWidget, how is the performance if we would display the JSON as a string in such case?

rouault added a commit to rouault/QGIS that referenced this pull request Feb 19, 2024
@rouault
QgsGmlStreamingParser: fix quadratic performance pattern when parsing…
b281083 
… huge JSON content

Addresses issue with qgis#55847 (comment)
and parsing of "https://www.wfs.nrw.de/geobasis/wfs_nw_inspire-gewaesser-netzwerk_atkis-basis-dlm?SERVICE=WFS&REQUEST=GetFeature&VERSION=2.0.0&TYPENAMES=net:Network&COUNT=1&SRSNAME=urn:ogc:def:crs:EPSG::25832&NAMESPACES=xmlns(net,http://inspire.ec.europa.eu/schemas/net/4.0)&NAMESPACE=xmlns(net,http://inspire.ec.europa.eu/schemas/net/4.0"
which is a 44 MB single WFS feature...
@rouault
[WFS provider] Handle documents with Complex Feature schemas (using O…
83fe2fe 
…GR GMLAS driver), and JSON'ify content of complex properties

Funded by QGIS user group Germany (QGIS Anwendergruppe Deutschland e.V.)
@rouault
[WFS provider] Better take into account case of GML geometry element …
b46a452 
…(readAttributesFromSchemaWithGMLAS)
@rouault
[WFS provider] Better take into account case where geometry element i…
c67d4e0 
…s optional (minOccurs=0)
@rouault
[WFS provider] Set OGR GMLAS XSD cache in a subdirectory of 'cache/di…
e3d24f8 
…rectory' setting, and make it clearable through Settings -> Options-> Network -> Cache Settings
@rouault
[WFS provider] Silence harmless warnings coming from GMLAS driver
1b436df
@rouault
QgsGmlStreamingParser: fix quadratic performance pattern when parsing…
95e3e37 
… huge JSON content

Addresses issue with qgis#55847 (comment)
and parsing of "https://www.wfs.nrw.de/geobasis/wfs_nw_inspire-gewaesser-netzwerk_atkis-basis-dlm?SERVICE=WFS&REQUEST=GetFeature&VERSION=2.0.0&TYPENAMES=net:Network&COUNT=1&SRSNAME=urn:ogc:def:crs:EPSG::25832&NAMESPACES=xmlns(net,http://inspire.ec.europa.eu/schemas/net/4.0)&NAMESPACE=xmlns(net,http://inspire.ec.europa.eu/schemas/net/4.0"
which is a 44 MB single WFS feature...
@rouault
[WFS provider] readAttributesFromSchemaWithGMLAS(): make sure geomTyp…
3c846a4 
…e is properly initialized to NoGeometry when there's no geometry field
@rouault
JSONEditWidget: fix performance issues with too large arrays in tree …
4a12c84 
…view mode
@rouault
[GUI] Attribute table: truncate too large strings to avoid performanc…
c87df1f 
…e issues
@rouault
[WFS provider] Change feature paging enabled option to be tri-state (…
c61231f 
…default, enabled, disabled), to allow a user to effectively override server capabilities
@rouault
[WFS provider] Fix discovery of geometry attribute when partially rec…
34a5f1e 
…ognized by regular analysis of DescribeFeatureType and then handled by GMLAS based analysis
@rouault
QgsGmlStreamingParser: in JSON attribute mode, robustify against geom…
5d472d2 
…etry elements in unexpected places
@rouault
[WFS provider] readAttributesFromSchemaWithoutGMLAS(): also retry wit…
2dae2d7 
…h GMLAS driver when no attribute has been found

Fixes case of qgis@8eb189b
@rouault
[WFS provider] Add support for geometry element using gml:GeometricPr…
e198ffd 
…imitivePropertyType
@rouault
QgsGmlStreamingParser::startElement(): make clang-tidy happy
dee8b48
@rouault
[WFS provider] querySublayers(): workaround servers that declare geom…
3966603 
…etry type filters, but which are not working
@rouault
[WFS provider] If GMLAS analysis failed, write error to message log
927d7ab
@rouault
QgsVectorLayerUtils::guessFriendlyIdentifierField(): improve heuristi…
f017314 
…cs to work better with WFS layers analyzed with the GMLAS driver
@rouault
Copy link
Contributor Author

rouault commented Feb 19, 2024 •
edited

Rebased on top of latest master to get #56403 fix, and hacky commit dropped

@rouault rouault merged commit ca336f7 into qgis:master Feb 20, 2024
30 checks passed
@nyalldawson
Copy link
Collaborator

@rouault there's test failures after this merge -- see eg #56421

@rouault rouault mentioned this pull request Feb 20, 2024
Merged
@rouault
Copy link
Contributor Author

rouault commented Feb 20, 2024

@rouault there's test failures after this merge -- see eg #56421

Should be fixed per #56429

ralphraul pushed a commit to 1SpatialGroupLtd/gdal that referenced this pull request Mar 11, 2024
@rouault @ralphraul
GMLAS: recognize GeometricPrimitivePropertyType
d713256 
such as in https://www.wfs.nrw.de/geobasis/wfs_nw_inspire-gewaesser-physisch_atkis-basis-dlm?SERVICE=WFS&REQUEST=DescribeFeatureType&VERSION=2.0.0&TYPENAMES=hy-p:Embankment&NAMESPACES=xmlns(hy-p,http://inspire.ec.europa.eu/schemas/hy-p/4.0)&TYPENAME=hy-p:Embankment&NAMESPACE=xmlns(hy-p,http://inspire.ec.europa.eu/schemas/hy-p/4.0)

Cf qgis/QGIS#55847 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathmapper pathmapper pathmapper left review comments

@elpaso elpaso elpaso approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
3.36.0
4 participants
@rouault @pathmapper @nyalldawson @elpaso