Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Insure that added/removed fields are taken into account by the attribute form panel #55938

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jan 23, 2024

Description

This PR fixes a long-standing issue whereas adding or deleting fields through the vector layer properties dialog would leave the dialog's attribute form panel out-of-sync, leaving users with no option other than closing and re-opening the dialog to see the newly added field(s). The PR also fixes a related problem when joining layers resulting in fields added to the layer.

Fixes #26350.

Copy link

github-actions bot commented Jan 23, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 199373a)

@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Jan 25, 2024

@nirvn, is the fixed issue the same as the one also recently reported at #55533?

@nirvn nirvn enabled auto-merge (rebase) January 31, 2024 03:23
@nirvn nirvn closed this Feb 4, 2024
auto-merge was automatically disabled February 4, 2024 06:51

Pull request was closed

@nirvn nirvn reopened this Feb 4, 2024
@nirvn nirvn enabled auto-merge (rebase) February 4, 2024 06:51
@agiudiceandrea
Copy link
Contributor

@nirvn, what about #55533?

@nirvn
Copy link
Contributor Author

nirvn commented Feb 4, 2024

@agiudiceandrea , completely different issue.

@nirvn nirvn merged commit 212d5f7 into qgis:master Feb 4, 2024
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to close the layer properties dialog before a newly created field appears in Attribute form
5 participants