fix issues with align dash pattern (fix #45432) #55969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
added
Symbology
nyalldawson
added
backport release-3_34
and removed
backport queued_ltr_backports
nyalldawson
reviewed
Jan 24, 2024
nyalldawson
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dash pattern values are multiplied by "Stroke width"
pen.widthF()before setting it to =>1 value, resulting in infinite loop. AlsopatternIndexis not updated correctly when zero length gap is present in dash pattern causing out of bounds error.Fixes #45432, supersedes #45759.