Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a QgsScrollArea when adding or inserting pages to QgsOptionsDialogBase #55978

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Jan 24, 2024

Description

Most pages in QgsOptions encapsulate their contents within a hard coded QgsScrollArea to allow for scrollbars when shrinking.
However, many pages in options and other subclasses use the QgsOptionsDialogBase::insertPage or QgsOptionsDialogBase::addPage and force a minimum height to the parent dialog which is often quite big. This can also happen by plugins that add a page to the project properties or options dialog.
With this PR, all pages added with those methods are wrapped around a QgsScrollArea and now all QgsOptionsDialogBase derived dialogs can be resized to fit in smaller screens.

Peek 2024-01-24 18-07

Properly fixes the already closed #32021

@github-actions github-actions bot added this to the 3.36.0 milestone Jan 24, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 4223130)

@nyalldawson nyalldawson merged commit ae6abed into qgis:master Feb 1, 2024
31 checks passed
@agiudiceandrea
Copy link
Contributor

Hi @uclaros, please see #56381. I think that issue may be related to this PR.

@uclaros
Copy link
Contributor Author

uclaros commented Feb 16, 2024

Good catch!
#56384 should fix this

@agiudiceandrea
Copy link
Contributor

Thank you for your super fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog windows are too tall for some screens, rendering them unusable
3 participants