Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIN: Add a workaround in reading WKT/WKB #56071

Closed
wants to merge 1 commit into from

Conversation

lbartoletti
Copy link
Member

Description

There is currently no class for managing TIN in QGIS. A TIN is essentially a kind of multipolygon (multi-triangle, as in the OGC sense, a triangle is a specific type of polygon).
This commit enables reading a TIN WKB/WKT and "converts" it into a multipolygon. A dedicated TIN class will be proposed later, after the feature freeze ends and for new QGIS versions.

Funded by : Oslandia, SFCGAL and QGIS

@github-actions github-actions bot added this to the 3.36.0 milestone Jan 29, 2024
@lbartoletti lbartoletti self-assigned this Jan 29, 2024
Copy link

github-actions bot commented Jan 29, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 2cb0434)

@nyalldawson
Copy link
Collaborator

I don't think this is suitable for backporting -- it should wait for 3.38 instead.

@@ -194,6 +194,7 @@ class CORE_EXPORT Qgis
CurvePolygon = 10, //!< CurvePolygon
MultiCurve = 11, //!< MultiCurve
MultiSurface = 12, //!< MultiSurface
TIN = 16, //!< TIN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TIN = 16, //!< TIN
TIN = 16, //!< TIN (since QGIS 3.38)

elsewhere too

@nyalldawson
Copy link
Collaborator

@lbartoletti
Copy link
Member Author

I don't think this is suitable for backporting -- it should wait for 3.38 instead.

Why 3.38?

I think, it's OK for 3.36 as a "cast" to multipolygon. For 3.38, I expect to add a true QgsTIN class.

There is currently no class for managing TIN in QGIS.
A TIN is essentially a kind of multipolygon (multi-triangle, as in the OGC sense,
a triangle is a specific type of polygon).
This commit enables reading a TIN WKB/WKT and "converts" it into a multipolygon.
A dedicated TIN class will be proposed later, after the feature freeze ends and
for new QGIS versions.
@nyalldawson
Copy link
Collaborator

Why 3.38?
I think, it's OK for 3.36 as a "cast" to multipolygon. For 3.38, I expect to add a true QgsTIN class.

What's the benefit in getting just the type in before this? Wouldn't that break things like round trips through wkb?

@lbartoletti
Copy link
Member Author

Why 3.38?
I think, it's OK for 3.36 as a "cast" to multipolygon. For 3.38, I expect to add a true QgsTIN class.

What's the benefit in getting just the type in before this? Wouldn't that break things like round trips through wkb?

After reflection and internal discussion, I have decided to abandon this workaround in favor of implementing full support for TIN (Triangulated Irregular Network) and PolyhedralSurface to fully comply with OGC (Open Geospatial Consortium) Simple Feature standards in version 3.38.

@lbartoletti lbartoletti closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants