New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG: faster information retrieval for table info #56090
PG: faster information retrieval for table info #56090
Conversation
Information about single tables does not need to scan for all tables anymore. Fix qgis#56069
I appreciate the goal of this PR but adding another parameter to the existing overcomplex function doesn't seem the best approach here. Had you considered creating a new simplified function to fetch info about a single table ? Parameters like "searchGeometryColumnsOnly" or "searchPublicOnly" do not make any sense with a function that's asked for a specific table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've bumped into this as well when accessing slow remote databases!
Any chance to get this backported into 3.34 (so it lands in LTR soonish) in exchange for some German Marzipan if I make to Slovakia in September? 😊 |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_34 release-3_34
# Navigate to the new working tree
cd .worktrees/backport-release-3_34
# Create a new branch
git switch --create backport-56090-to-release-3_34
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 1ed4113ef1c60ef612e4855c091b80f52ece5c4b,f182d76615f521c514d0a507b8891fe382d780c5,c4898c1fede5a113f52a86de247f2bc77e120484,46a5ddd25164408fe35e0bc5340663d2f813864d
# Push it to GitHub
git push --set-upstream origin backport-56090-to-release-3_34
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_34 Then, create a pull request where the |
Information about single tables does not need to
scan for all tables anymore.
Fix #56069