New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize extract nodes algorithm #5612
Conversation
Looks good! |
Nice speed gain: 20.89sec (python) vs 15.36sec (native c++) for a large-ish polygon dataset resulting in 51,000 points. |
@nyalldawson , as suggested, I'm now using a vertex iterator. For the record, it didn't lead to great speed gains. The same dataset now takes 15.13sec, virtually no gain here. |
7fb2ef9
to
b0d99d5
Compare
@m-kuhn , any idea why the tests fail with precision? |
Fixed - using precision wasn't working if a NULL value was present in an attribute |
@nyalldawson , I am once again humbled 馃槈 |
Description
This PR optimizes the extract nodes algorithm by upgrading it to native C++. I've also added a couple of tags to the algorithm to ease its discoverability (let's not throw people into SAGA for such a simple task 馃槈)
@nyalldawson , your review would be appreciated.
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit