[dxf] When exporting to DXF, skip empty layers #56126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Feb 3, 2024
|
@nirvn should we add some feedback mechanism here to advise the user why the layer was skipped? |
|
@nyalldawson , feedback added. |
nyalldawson
reviewed
Feb 4, 2024
nirvn
force-pushed
the
dxf_output_skip_empty_layer
branch
2 times, most recently
from
dd4a80b
to
df55102
Compare
nirvn
force-pushed
the
dxf_output_skip_empty_layer
branch
from
df55102
to
840fd93
Compare
nyalldawson
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR insures that the LAYER groups are only written into the DXF when features are found within those layers. If no features are found (empty layer or no feature overlapping the provided extent), we write nothing.
Test cases were added to cover pre-existing filtering by extent and this additional handling of empty layers.