New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch potential QgsCsException at various places; improve qgscoordinatetransform.h doc #56212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
QgsCsException
branch
from
February 6, 2024 18:46
ecafbe0
to
00ed8fc
Compare
nyalldawson
approved these changes
Feb 7, 2024
…ion ), and add Doxygen \throw hint to make it obvious exceptions might be thrown
rouault
force-pushed
the
QgsCsException
branch
from
February 7, 2024 02:16
00ed8fc
to
f9835d5
Compare
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_34 release-3_34
# Navigate to the new working tree
cd .worktrees/backport-release-3_34
# Create a new branch
git switch --create backport-56212-to-release-3_34
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick d43ceb45b64b2715f55cb19e1aa3a91aa219ac1f,c9079645f1ef21e7fda7b64d83587e7d58b345ee,fa4da34df21f33888b3c0a686657d0493f5b7e36,fecc5ed6d73ab55cead4ef9235fd42f98f49c355,f9835d5f4d66ae1f1c200a5f3957cf8e3bba9936
# Push it to GitHub
git push --set-upstream origin backport-56212-to-release-3_34
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_34 Then, create a pull request where the |
qgis-bot
added
the
failed backport
The automated backport attempt failed, needs a manual backport
label
Feb 7, 2024
manually backported in #56244 |
rouault
removed
the
failed backport
The automated backport attempt failed, needs a manual backport
label
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.