[backport] qgspostgresprovider: Fix primary key retrieval with lowercase option #56259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `lowercaseFieldNames` allows to transform the column names to lowercase. If this option is enabled, then the requested primary key (`primaryKey`) is in lowercase but the `fields` are not. Therefore, the requested primary key will never be found. This issue is fixed by converting the field names to lowercase when looking for the primary key if the option is enabled. Closes: qgis#55856
rouault
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 3.34 backport of #56243
The
lowercaseFieldNamesallows to transform the column names to lowercase. If this option is enabled, then the requested primary key (primaryKey) is in lowercase but thefieldsare not. Therefore, the requested primary key will never be found.This issue is fixed by converting the field names to lowercase when looking for the primary key if the option is enabled.
Closes: #55856