[processing] Don't try to interpret distance widget value as CRS #56292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a logic error in QgsProcessingDistanceWidgetWrapper::setUnitParameterValue which meant that when the linked crs parameter value was unset, we incorrectly took the default value from the DISTANCE parameter and tried to intrepret it as a CRS. In practice, this meant we'd take a value like "100" and then try to turn that into a CRS. Since it doesn't match any possible CRS definition, the fallback code would try to interpret it as a map layer and ultimately try to load "100" as a OGR vector layer. No real issue in doing that, but it results in a bunch of silly debug spam...!
alexbruy
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a logic error in QgsProcessingDistanceWidgetWrapper::setUnitParameterValue which meant that when the linked crs parameter value was unset, we incorrectly took the default value from the DISTANCE parameter and tried to intrepret it as a CRS.
In practice, this meant we'd take a value like "100" and then try to turn that into a CRS. Since it doesn't match any possible CRS definition, the fallback code would try to interpret it as a map layer and ultimately try to load "100" as a OGR vector layer.
No real issue in doing that, but it results in a bunch of silly debug spam...!