Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a deadlock with local COPC files in 2D rendering #56432

Merged
merged 1 commit into from
Feb 21, 2024

Commits on Feb 20, 2024

  1. Fix a deadlock with local COPC files in 2D rendering

    Follow up of qgis#56388
    
    It was possible to trigger a deadlock when using a local COPC file
    by zooming in/out while there was 2D rendering happening - this caused
    a situation where point cloud index was trying to recursively lock
    a mutex that the same thread has already locked.
    
    fetchNodeHierarchy() for local COPC files now unlocks the mutex before
    calling fetchHierarchyPage() just like what happens with remote COPC files.
    
    While fixing that, I have removed now duplicate code between the local and
    remote COPC support. The logic for dealing with hierarchy mutex should
    be clearer now as well - we do not call other functions of the index
    with mutex locked.
    wonder-sk committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e5ce4c5 View commit details
    Browse the repository at this point in the history