[wms] Fix handling of mbtiles in paths containing non-latin characters #56462
Conversation
Tests failed for Qt 6One or more tests failed using the build from commit eb21fbb composermap_render (render)composermap_renderTest failed at render at tests/src/core/testqgslayoutmap.cpp:185 Rendered image did not match tests/testdata/control_images/composer_map/expected_composermap_render/expected_composermap_render.png (found 13824 pixels different) composermap_overview_center (overviewMapCenter)composermap_overview_centerTest failed at overviewMapCenter at tests/src/core/testqgslayoutmapoverview.cpp:224 Rendered image did not match tests/testdata/control_images/composer_mapoverview/expected_composermap_overview_center/expected_composermap_overview_center.png (found 116 pixels different) flat_terrain_2 (testFlatTerrain)flat_terrain_2Test failed at testFlatTerrain at tests/src/3d/testqgs3drendering.cpp:316 Rendered image did not match tests/testdata/control_images/3d/expected_flat_terrain_2/expected_flat_terrain_2.png (found 2725 pixels different) dem_terrain_1 (testDemTerrain)dem_terrain_1Test failed at testDemTerrain at tests/src/3d/testqgs3drendering.cpp:363 Rendered image did not match tests/testdata/control_images/3d/expected_dem_terrain_1/expected_dem_terrain_1.png (found 1603 pixels different) 4978_line_rendering_2 (testEpsg4978LineRendering)4978_line_rendering_2Test failed at testEpsg4978LineRendering at tests/src/3d/testqgs3drendering.cpp:1293 Rendered image did not match tests/testdata/control_images/3d/expected_4978_line_rendering_2/expected_4978_line_rendering_2.png (found 128045 pixels different) phong_shading (testPhongShading)phong_shadingTest failed at testPhongShading at tests/src/3d/testqgs3drendering.cpp:503 Rendered image did not match tests/testdata/control_images/3d/expected_phong_shading/expected_phong_shading.png (found 54 pixels different) metal_rough (testExtrudedPolygonsMetalRoughShading)metal_roughTest failed at testExtrudedPolygonsMetalRoughShading at tests/src/3d/testqgs3drendering.cpp:649 Rendered image did not match tests/testdata/control_images/3d/expected_metal_rough/expected_metal_rough.png (found 51 pixels different) line_rendering_2 (testLineRendering)line_rendering_2Test failed at testLineRendering at tests/src/3d/testqgs3drendering.cpp:761
dem_terrain_filtered_1 (testFilteredDemTerrain)dem_terrain_filtered_1Test failed at testFilteredDemTerrain at tests/src/3d/testqgs3drendering.cpp:1370 Rendered image did not match tests/testdata/control_images/3d/expected_dem_terrain_filtered_1/expected_dem_terrain_filtered_1.png (found 3886 pixels different) composermap_overview_centercomposermap_overview_centerTest failed at testOverviewMapCenter at tests/src/python/test_qgslayoutmapoverview.py:161 Rendered image did not match tests/testdata/control_images/composer_mapoverview/expected_composermap_overview_center/expected_composermap_overview_center.png (found 116 pixels different) composermap_overview_belowmapcomposermap_overview_belowmapTest failed at testOverviewStacking at tests/src/python/test_qgslayoutmapoverview.py:333 Rendered image did not match tests/testdata/control_images/composer_mapoverview/expected_composermap_overview_belowmap/expected_composermap_overview_belowmap.png (found 580 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
|
This definitely needs some tests 😄 |
|
@nyalldawson , yeah for sure, it was late yesterday and wanted to push the change through to get a CI run through while I was sleeping. Test coming. |
nirvn
force-pushed
the
wms_mbtiles_world
branch
from
36a46b4
to
eb21fbb
Compare
|
@nyalldawson , test added. |
Description
This PR fixes the loading of mbtiles dataset through our WMS provider when the file path contains non-latin characters. Should make quite a few people around the world happy :wink
Proof of life:
Fixes #56023.