Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-3_34] [annotations] Do not process empty geometries when adding line/polygon annotations #56470

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[Backport release-3_34] [annotations] Do not process empty geometries when adding line/polygon annotations #56470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/gui/annotations/qgscreateannotationitemmaptool_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ QgsCreateLineItemMapTool::QgsCreateLineItemMapTool( QgsMapCanvas *canvas, QgsAdv

void QgsCreateLineItemMapTool::lineCaptured( const QgsCurve *line )
{
if ( line->isEmpty() )
return;

// do it!
std::unique_ptr< QgsAbstractGeometry > geometry( line->simplifiedTypeRef()->clone() );
if ( qgsgeometry_cast< QgsCurve * >( geometry.get() ) )
Expand Down Expand Up @@ -195,6 +198,9 @@ QgsCreatePolygonItemMapTool::QgsCreatePolygonItemMapTool( QgsMapCanvas *canvas,

void QgsCreatePolygonItemMapTool::polygonCaptured( const QgsCurvePolygon *polygon )
{
if ( polygon->isEmpty() )
return;

std::unique_ptr< QgsAbstractGeometry > geometry( polygon->exteriorRing()->simplifiedTypeRef()->clone() );
if ( qgsgeometry_cast< QgsCurve * >( geometry.get() ) )
{
Expand Down Expand Up @@ -226,6 +232,9 @@ QgsCreateLineTextItemMapTool::QgsCreateLineTextItemMapTool( QgsMapCanvas *canvas

void QgsCreateLineTextItemMapTool::lineCaptured( const QgsCurve *line )
{
if ( line->isEmpty() )
return;

// do it!
std::unique_ptr< QgsAbstractGeometry > geometry( line->simplifiedTypeRef()->clone() );
if ( qgsgeometry_cast< QgsCurve * >( geometry.get() ) )
Expand Down
Loading