-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix merge features with hidden fields #56825
Fix merge features with hidden fields #56825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just added few minor comments 😄
d6d0395
to
3614991
Compare
@nyalldawson could you review this as well? |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Not stale, just waiting for review. Could perhaps some of you @nyalldawson, @3nids, @m-kuhn please review this? |
d3e0639
to
dffda6f
Compare
dffda6f
to
ad26225
Compare
ad26225
to
f7ac019
Compare
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Again not stale and just waiting for the GitHub actions to run. Could you @elpaso allow them to run, thanks again! |
Can you try to rebase from current master an force-push? |
Instead of ignoring always hidden fields, use field default value or value from one of merged features. Fixes qgis#28253 Co-authored-by: Joonalai <joona.laine@cofactor.fi>
Head branch was pushed to by a user without write access
f7ac019
to
57cc7ed
Compare
@vaahtokarkki thank you for you contribution. |
@elpaso there does not seem to be a backport PR of this fix for release-3_34? Should we make it manually or is "Backport queued_ltr_backports" ending up to some 3.34 release? |
queued_ltr_backports will be merged in 3.34 but not in the next point release, we skip one point release to give extra time for testing before merging into a LTR. |
Description
Merge selected features tool won't merge correctly hidden attribute values. With this PR the tool will use for hidden fields the default value defined for field, or the value from the selected feature, if any is selected.
Fixes #28253
Backport needed for 3.34 and 3.36