[bugfix][postgres] Browser panel D&D a layer onto a postgresql connection tree …

[elpaso]

…node icon fails without notice and leaving the destination table half-constructed ...

Fixes #17518 by defaulting to "public" if no schema is given

With test.

[elpaso]

@jef-n does it make sense to you? Or is there a better logic to get the "default" schema?

[jef-n]

Doesn't say what the problem with the missing schema name is. Knowing which schema to refresh? Otherwise creating the table without the schema will do the right thing anyway.

[elpaso]

@jef-n have a look to the test that I've added: it fails (badly, because it creates part of the table but not the geometry or attributes) on 2.x and master because the schema is not specified when creating the empty layer.

The problem with the empty schemaName resides in how the sql is constructed, if it's empty the sql will be ill-formed.

[elpaso]

@jef-n I guess that instead of setting the default to "public" we could also change the logic that build the sql strings, but I didn't check wether AddGeometryColumn works without the schema.

[jef-n]

the empty schema case needs to be handled everywhere (at least when checking whether the table exists and when calling AddGeometryColumn). Maybe by replacing schemaName with "current_schema" when it's empty and quotedValue(schemaName) when it's not. Alternatively there are also variants of AddGeometryColumn that don't need a schema.

[jef-n]

Ok, what I meant was schemaName = schemaName.isEmpty() ? "current_schema" : quotedValue(schemaName); here and schemaName instead of quotedValue(schemaName) below. Just one query less ;)

[elpaso]

I checked on psql and you cannot use current_schema to prefix a table. That's why I added an extra query to retrieve its value.

[jef-n]

you don't need to. a not prefixed table lands in the current schema