update HTML data provider metadata #5700
Conversation
| @@ -510,8 +510,7 @@ class CORE_EXPORT QgsRasterDataProvider : public QgsDataProvider, public QgsRast | |||
| //! \note not available in Python bindings | |||
| static QStringList cStringList2Q_( char **stringList ) SIP_SKIP; | |||
|
|
|||
| static QString makeTableCell( const QString &value ); | |||
| static QString makeTableCells( const QStringList &values ); | |||
| static QString makeHtmlBulletList( const QStringList &values ); | |||
There was a problem hiding this comment.
Can this methods be private? Possibly even a generic QgsHtmlUtils class would be nice to create the same kind of lists throughout QGIS.
Mainly it shouldn't be exposed by the raster data api.
There was a problem hiding this comment.
Yes, better! It's fixed.
Gustry
force-pushed
the
raster_provider
branch
2 times, most recently
from
310fbbd
to
616da5b
Compare
src/core/qgshtmlutils.cpp
Outdated
| { | ||
| QString s( QStringLiteral( "<ul>" ) ); | ||
|
|
||
| for ( QStringList::const_iterator i = values.begin(); |
There was a problem hiding this comment.
How about a for ( const QString &value : values ) loop?
src/core/qgshtmlutils.cpp
Outdated
| i != values.end(); | ||
| ++i ) | ||
| { | ||
| s += QLatin1String( "<li>" ) + *i + QLatin1String( "</li>" ); |
There was a problem hiding this comment.
If in doubt, use a template based approach QStringLiteral( "<li>%1</li>" ).arg( value );
src/core/qgshtmlutils.h
Outdated
| * \ingroup coregit st | ||
| * \class QgsHtmlUtils | ||
| * \brief Class for HTML utilities. | ||
| * \since QGIS 3.0 |
There was a problem hiding this comment.
It's fixing bug https://issues.qgis.org/issues/17504 so 3.0, Is-it not possible?
BTW, I will fix the + * \ingroup coregit st visible here L24
There was a problem hiding this comment.
Wasn't sure, if it fixes a bug, 3.0 is the way to go 👍
Gustry
force-pushed
the
raster_provider
branch
3 times, most recently
from
88b15cf
to
06ea959
Compare
|
Failing test seems unrelated to the PR https://dash.orfeo-toolbox.org/viewTest.php?onlyfailed&buildid=299224 |
Gustry
force-pushed
the
raster_provider
branch
from
06ea959
to
4273ad2
Compare
|
Travis is happy again. Anything to else to fix? |
|
Can we merge this PR? Thanks |
|
Thanks @Gustry ! |
* update HTML data provider metadata for grass, gdal and ams * update HTML data provider metadata for WMS and WCS * move HTML bullet list to QgsHtmlUtils
Description
Bringing back the HTML metadata from the raster provider. (Pixel size, dimension, Origin etc ...)
No more the old
glossy. I can still improve the CSS laterThis PR only updates the old HTML
Tickets:
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit