Update RMC NMEA 4.1 #57204
Merged
Update RMC NMEA 4.1 #57204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new item: navstatus
|
@bettellam , is there something missing here? When we discussed this, you mentioned the parser code needed tweaking. |
Update RMC sentence for NMEA v4.1
|
@nirvn Yes you're right, I made a mistake, the other piece of code ended up in a second patch!! |
nyalldawson
reviewed
May 1, 2024
nyalldawson
approved these changes
May 1, 2024
|
I vote for backporting to 3.36 and queue for 3.34 LTR. Without this fix, GNSS devices using the NMEA 4.1 spec are not working when switching to high accuracy. |
|
Backporting sounds good |
This was referenced May 1, 2024
|
@nyalldawson @nirvn - Test with receiver using NMEA v4.1 (UNICORECOMM UM982) all OK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new item for RMC sentence NMEA v4.1