[Backport release-3_36] QgsProject: The flag to read extent from xml was set too late #57297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `QgsProject::addLayer` method which add a layer from DOM layer element uses the method `projectFlagsToLayerReadFlags` to get layer read flags from project flags. The generated layer read flags is used into the `QgsMapLayer::readLayerFromXml` method. This method read the extent from XML only if the `QgsMapLayer::FlagReadExtentFromXml` flag is set. If it is not set, the layer extent (provided by the provider) and layer extent from xml are empty. So even if the read extent from xml is set to true for vector layer, the extent will be always provided by the provider if the flag `QgsMapLayer::FlagReadExtentFromXml` is not provided to `QgsMapLayer::readLayerFromXml` method. To fix it, we proposed to update `QgsProject::projectFlagsToLayerReadFlags` method to provide `QgsMapLayer::FlagReadExtentFromXml` from project flags. Funded by Tenergie
rldhont
added
Data Provider
|
Not related tests failed : 136 - test_core_networkaccessmanager (Timeout) |
troopa81
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #57219
Authored by: @rldhont