Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set network cache size >= 2 GiB (Fix #57380) #57403

Merged
merged 1 commit into from
May 13, 2024

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented May 13, 2024

Description

This PR avoids an overflow in the network cache size setting and a crash when the network size setting is set to a value equal or grater then 2097152 KiB (i.e. >= 2GiB).
This PR allows to set the network cache size up to 2147483647 KiB (i.e. 2 TiB - 1 KiB).

Fixes #57380.

@agiudiceandrea agiudiceandrea added Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_34 backport release-3_36 labels May 13, 2024
@github-actions github-actions bot added this to the 3.38.0 milestone May 13, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 92438d9)

@nyalldawson nyalldawson merged commit b8cfddd into qgis:master May 13, 2024
40 checks passed
@agiudiceandrea agiudiceandrea deleted the fix-57380-network-cache branch May 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3_34 Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting very high cache size crashes QGIS at startup
2 participants