Speed up QgsRenderChecker #57433
Merged
Speed up QgsRenderChecker #57433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are comparing images we've generated as part of the render check, avoid force round tripping these through PNG files. Instead, just keep the rendered QImage around and reuse it instead of creating a new image. Also avoid writing the rendered image to disk when the test passes successfully. (Will keep temp folders cleaner!)
troopa81
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary work when tests pass, and optimise the comparison of reference images
Cuts down the runtime for labeling tests to about 60% of previous times.