Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect buffers drawn for html label items #57551

Merged
merged 1 commit into from
May 24, 2024

Conversation

nyalldawson
Copy link
Collaborator

When a layout item uses a html enabled text format and has buffers enabled, the buffers would be incorrectly horizontally placed

When a layout item uses a html enabled text format and has buffers
enabled, the buffers would be incorrectly horizontally placed
@github-actions github-actions bot added this to the 3.38.0 milestone May 24, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 5d5fa73)

@nyalldawson nyalldawson merged commit f30ca52 into qgis:master May 24, 2024
36 checks passed
@nyalldawson nyalldawson deleted the fix_buffer_placement branch May 24, 2024 02:45
@qgis-bot
Copy link
Collaborator

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1
stderr
error: could not apply 5d5fa73df4d... Fix incorrect buffers drawn for html label items
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout
Auto-merging tests/src/python/test_qgstextrenderer.py
CONFLICT (content): Merge conflict in tests/src/python/test_qgstextrenderer.py

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-57551-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 5d5fa73df4d65c3180cab92d33b5c333f44fc38a
# Push it to GitHub
git push --set-upstream origin backport-57551-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-57551-to-queued_ltr_backports.

@qgis-bot qgis-bot added the failed backport The automated backport attempt failed, needs a manual backport label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports failed backport The automated backport attempt failed, needs a manual backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants