Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin manager background for dark themes #57697

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ivanbarsukov
Copy link
Contributor

Description

The explicitly set window color was making text unreadable when using the dark theme. Removing this styles allows the system to choose the appropriate color

Before

image

After

image
image

@github-actions github-actions bot added this to the 3.38.0 milestone Jun 6, 2024
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 21, 2024
@borysiasty borysiasty self-assigned this Jun 22, 2024
@ivanbarsukov ivanbarsukov force-pushed the plugin_manager_background_fix branch from 8cf0b7a to 61768df Compare June 22, 2024 16:56
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 22, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 61768df)

Copy link
Member

@borysiasty borysiasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works fine here :)

@borysiasty borysiasty merged commit ef06dae into qgis:master Jun 24, 2024
28 checks passed
@borysiasty borysiasty modified the milestones: 3.38.0, 3.40.0 Jun 24, 2024
@borysiasty
Copy link
Member

Btw. I've bumped the milestone up to 3.40 as you haven't set the backport release-3_38 label. But of course it's not my vote against backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants