-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect attempts to load outputs from models to projects #57701
Conversation
We should first check whether each individual output is set to load into the project before setting properties relating to loading the output, otherwise they all get appended to the add to project list. Fixes qgis#57698
If true, then the evaluated result won't be treated as an actual layer to load
This is an advance test only, and shouldn't result in layers attempting to add to the project. Refs qgis#57698
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool, you post an issue just before you go to sleep and when you wake up it's fixed 😄
Thanks @nyalldawson, confirmed this fixes #57698 and additionally also #54865 🎉
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-57701-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ed5a41f4082b4a0c6a1d501b96780ab610c60f25,e6baabe229e9eec8bc7f1732881c1e79475636ad,dcf88ddb8ddecd3b964850b78acb2d5e354e54aa
# Push it to GitHub
git push --set-upstream origin backport-57701-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
Fixes #57698