Don't show invalid "Style not found in database" warning when adding vector tile layers #57714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would an additional param |
…vector tile layers The API here is a mess -- since we use the same API for user-triggered intentional style loads and ALSO the attempt to sniff and see if a layer has a default style (when it may not), there's a mixup of whether or not we should report missing styles as an error or not. This results in a misleading "style not found in database" error shown when adding vector tile layers. Other layer types just ignore the return code and don't show warnings, but for vector tiles the API returns valid warnings when loading styles which we DO want to be user visible. Just hack around this by hiding the one particular unwanted warning for now.
We can't fix the API without a significant break here.
nyalldawson
force-pushed
the
invalid_warn
branch
from
2cbe120
to
ec29245
Compare
I've done what I can with the API now, but we can't fix the ultimate issues until QGIS 4.0. Lots of TODOs added now 😉 |
m-kuhn
approved these changes
Jun 10, 2024
|
Thanks @nyalldawson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API here is a mess -- since we use the same API for user-triggered intentional style loads and ALSO the attempt to sniff and see if a layer has a default style (when it may not), there's a mixup of whether or not we should report missing styles as an error or not.
This results in a misleading "style not found in database" error shown when adding vector tile layers. Other layer types just ignore the return code and don't show warnings, but for vector tiles the API returns valid warnings when loading styles which we DO want to be user visible.
Just hack around this by hiding the one particular unwanted warning for now.