Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when printing or pdfing a composition when blend modes are present #579

Merged
merged 3 commits into from May 6, 2013

Conversation

nyalldawson
Copy link
Collaborator

Since QPainter doesn't support composition modes, this adds a warning message to tell the user to "print as raster" when a composition contains blending and they are attempting to print or pdf it.

(Discussed on qgis-dev here
http://lists.osgeo.org/pipermail/qgis-developer/2013-May/026001.html)

@nyalldawson
Copy link
Collaborator Author

@NathanW2 I'd appreciate a quick review of this before I commit it - in particular, whether you think the workflow is ok and also whether a3573ce and 5c240bc are the best ways to implement this.

@@ -2029,6 +2077,34 @@ void QgsComposer::showWMSPrintingWarning()
}
}

void QgsComposer::showBlendModePrintingWarning()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

nyalldawson added a commit that referenced this pull request May 6, 2013
Show warning when printing or pdfing a composition when blend modes are present
@nyalldawson nyalldawson merged commit 0cc7389 into qgis:master May 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants