[need-docs] reorganize the new spatialite layer dialog

[nirvn]

Description

The PR harmonizes the create spatialite layer dialog to match recent improvements done to the create geopackage layer dialog (and others).

Before vs. PR:

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include fixes #11111 in the commit message next to the description
• Commits which add new features are tagged with [FEATURE] in the commit message
• Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
• I have read the QGIS Coding Standards and this PR complies with them
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• New unit tests have been added for core changes
• I have run the scripts/prepare-commit.sh script before each commit

[nirvn]

@m-kuhn , BTW, while working on this, I noticed the autoincrementing fid field isn't marked as Autogenerated in the new feature attributes dialog that pops up. It's forcing the users to enter a value there, not the best UX.

[nyalldawson]

Nice work!

There's another ui inconsistency here... I think this dialog is the only place the proper crs selector combobox widget isn't used in QGIS. Is that straightforward to swap?

[nirvn]

@nyalldawson , can't be done unless there's a way to call setOgcWmsCrsFilter() through the projection selection widget.

[m-kuhn]

That's a spatialite issue. I think @elpaso recently looked into this.

[nirvn]

@m-kuhn , cool.

While refreshing the dialog, I noticed our spatialite provider driver doesn't support curved geometries too, while GDAL 2.x does support such geometry for spatialite datasets.

[nyalldawson]

While refreshing the dialog, I noticed our spatialite provider driver doesn't support curved geometries too, while GDAL 2.x does support such geometry for spatialite datasets.

Yet another compelling reason to kick it to the kerb and just always use GDAL for this...

[m-kuhn]

Yet another compelling reason to kick it to the kerb and just always use GDAL for this...

Major question for me here: if we create an aggregate expression compiler, can we

• detect which tables come from the same DB (I guess so)
• JOIN other tables from the DB within a request

CC @rouault